Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iButton Dallas DS1904 (RTC) support #3561

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

iButton Dallas DS1904 (RTC) support #3561

wants to merge 2 commits into from
+230 −0

Conversation

bettse
Copy link
Contributor

@bettse bettse commented Apr 2, 2024 •
edited

What's new

  • iButton Dallas DS1904 (RTC) support
  • Rough draft, I was targeting reading/writing of the iButtons since I don't have a way to test emulation.

Verification

  • Scan DS1904 and see it detected and time shown
  • TBD: How to handle "write" to set the clock and "device control byte"

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

bettse
bettse commented Apr 2, 2024
View reviewed changes
lib/ibutton/protocols/dallas/protocol_ds1904.c

static bool
dallas_ds1904_emulate_write_clock(OneWireSlave* bus, const uint8_t* device_control_byte) {
// What does it mean to write the clock of a virtualized RTC?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to validate emulation either

@skotopes
Copy link
Member

@doomwastaken can you get some samples of ds1904

@doomwastaken
Copy link
Member

ds1904
checked with two flippers and then there is difference when I emulate said key with flipper
ds1904-re-emulated
Also attaching you a key from flipper (change res to ibtn from txt). Only way I had to verify
1904.txt
is via key copier, but it only gives UID

@hedger hedger added New Feature Contains an IMPLEMENTATION of a new feature iButton labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes will be requested when the pull request is marked ready for review skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 will be requested when the pull request is marked ready for review DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger will be requested when the pull request is marked ready for review hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov will be requested when the pull request is marked ready for review gsurkov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
iButton New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bettse @skotopes @doomwastaken @hedger