Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plantain parser improvements #3469

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Plantain parser improvements #3469

wants to merge 3 commits into from

Conversation

assasinfil
Copy link
Contributor

What's new

  • Added more parsed lines: validator, balance, tariff, trip time, count...

Verification

  • Try to parse card and validate result with "Транспортные карты Москвы" or other parsing service.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@assasinfil assasinfil marked this pull request as ready for review February 20, 2024 14:13
@hedger hedger added NFC NFC-related New Feature Contains an IMPLEMENTATION of a new feature labels Feb 20, 2024
@assasinfil assasinfil marked this pull request as draft February 23, 2024 11:31
@gornekich
Copy link
Member

@assasinfil any news?

@assasinfil
Copy link
Contributor Author

Im awating support from @rozetkinrobot. It's still in progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@gornekich gornekich

Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@assasinfil @gornekich @hedger