Moscow social card parser #3464
Conversation
| config->data_sector = 15; | ||
| config->keys = social_moscow_1k_keys; | ||
| } else if(type == MfClassicType4k) { | ||
| config->data_sector = 15; |
There was a problem hiding this comment.
if I see it correctly, this will use key 0xa0a1a2a3a4a5, also for verification.
which then introduces the same false-positive problem that I just fixed in #3467 for the wash-city parser:
the 0xa0.. key is very commonly used and if any plugins verify func uses only that key, chances are high for false-positive , essentially breaking reading of alot cards
There was a problem hiding this comment.
I chose block 15 for verification as it contains the basic data of the social card, I agree that both keys A and B need to be checked at once.
There was a problem hiding this comment.
yes. I would suggest using two non-common keys for verification if its the right card. doesnt have to be the actual data-section, just unique enough to identify the proper card.
(if possible, add sanity-checks in the parse function = make sure it returns false if the parsed data doesnt make sense)
great work besides that remark 👍 :)
What's new
Verification
Checklist (For Reviewer)