Added a text input that only accepts full numbers (int) #3350

leedave · 2024-01-09T07:24:37Z

What's new

I've added a new Keyboard input. It is similar to text_input and byte_input. The purpose of this one is to only allow users to input a number, nothing else. This can be very handy in app designs, as the user input is limited to expected characters.

Verification

#include <gui/modules/int_input.h> in a fap application the same way you would include text_input.h

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix

hedger

Please also include the new header in "sdk_headers" for gui module. And update API CSV's for both f7 and f18 afterwards.

leedave · 2024-01-09T08:06:36Z

@hedger Thank you for the feedback.
Added the requested sdk_headers and CSV entries

leedave · 2024-01-11T09:04:32Z

@hedger are these fail messages normal or am I expected to do something to fix this?

skotopes · 2024-02-15T08:40:07Z

Sorry for delay with your PR.
Can you also provide example app and rename IntInput to NumberInput, int_input to number_input?

leedave · 2024-02-15T16:03:34Z

@skotopes
Ok, tried my best to keep it as expected. Let me know if something isn't right.

The keyboard is renamed
There is an example app in applications/examples/example_number_input

leedave · 2024-02-15T16:12:40Z

trim.7362EBC2-3BCF-48BD-AF7D-D92890EC4349.MOV

skotopes · 2024-02-16T04:02:18Z

0x0801147c in __furi_crash_implementation () at furi/core/check.c:163
163	        RESTORE_REGISTERS_AND_HALT_MCU(debug);
(gdb) bt
#0  0x0801147c in __furi_crash_implementation () at furi/core/check.c:163
#1  0x0807a5cc in view_dispatcher_free (view_dispatcher=0x20014de8) at applications/services/gui/view_dispatcher.c:26
#2  0x200154a6 in example_number_input_free (app=app@entry=0x20015a00) at applications/examples/example_number_input/example_number_input.c:45
#3  0x2001551e in example_number_input (p=<optimized out>) at applications/examples/example_number_input/example_number_input.c:69
#4  0x080548a2 in flipper_application_thread (context=0x20014b20) at lib/flipper_application/flipper_application.c:224
#5  0x08013d6e in furi_thread_body (context=0x20014d78) at furi/core/thread.c:91
#6  0x08013d1a in furi_thread_catch () at furi/core/thread.c:62
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

crashing on exit because some view was not released from view dispatcher

skotopes · 2024-02-16T04:04:53Z

applications/services/gui/modules/number_input.c

+            model->selected_row = 0;
+            model->selected_column = 0;
+            model->clear_default_text = false;
+            model->text_buffer = "";


I got feeling that this part was copied from another place. We are not proud with it )

General concept for view modules is that they should own their own buffer and then provide it in callback call.

skotopes · 2024-02-16T04:06:36Z

applications/services/gui/modules/number_input.c

+static const uint8_t enter_symbol = '\r';
+static const uint8_t backspace_symbol = '\b';
+
+static const NumberInputKey keyboard_keys_row_1[] = {


Since we talking about numbers(int) you may want to provide negative sign too.
Also it will be nice if limits(MIN/MAX) and maybe int size be adjustable

skotopes · 2024-02-16T04:07:53Z

Un-draft when ready

skotopes · 2024-02-16T04:12:20Z

also please fix build issues (API mismatch)

skotopes · 2024-04-19T10:51:26Z

@leedave need help?

leedave · 2024-04-19T14:34:16Z

@skotopes
Can you give me some more hints on the
view modules should own their own buffer issue.
Tbh I learn how code for Flipper should look by studying the fw you provide, as there is no official developer documentation. I got the basic setup from the other two keyboards (text & hex). If you say you're not proud of what you guys did back then and ask for an update, I'm not sure where I can find something built in the way you want to see it.

skotopes · 2024-04-19T14:36:48Z

@leedave change model->text_buffer type to FuriString and allocate it on your module allocation

leedave · 2024-04-19T14:45:28Z

@skotopes
How did you do the check, to see if some views were not removed from view_dispatcher. I added a code update, but lack a way of testing the result

* GUI: Fix array out of bounds in menu exit * Gui: fix incorrect empty menu handling * Gui: add missing item check in menu ok handling * Gui: remove dead code from menu module Co-authored-by: あく <alleteam@gmail.com>

Co-authored-by: あく <alleteam@gmail.com>

…velopment to spare compile time

leedave · 2024-05-17T21:31:00Z

So after a long wait, I finally managed to add your requests

model->text_buffer changed to FuriString
removed number digits length option
replaced with settings for min/max value allowed
added possibility to input negative numbers, added button if set to true when loading module

…nts it¿

leedave requested review from skotopes, DrZlo13 and hedger as code owners January 9, 2024 07:24

hedger added UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature labels Jan 9, 2024

hedger requested changes Jan 9, 2024

View reviewed changes

leedave requested a review from nminaylov as a code owner January 9, 2024 08:05

leedave requested a review from hedger January 9, 2024 08:18

leedave requested a review from gsurkov as a code owner January 16, 2024 13:27

skotopes requested changes Feb 16, 2024

View reviewed changes

skotopes marked this pull request as draft February 16, 2024 04:07

David Lee and others added 7 commits April 19, 2024 16:19

Added a text input that only accepts full numbers (int)

c039e64

Added to Gui sdk_headers and api_symbols in f7 and f18

186845a

Fixed _Bool declarations in symbols csv

b9a362c

renamed int_input to number_input

e79e130

Changed name & added example fap

365c588

formatting code

3e87482

Minor clenaup

6bfb322

David Lee and others added 8 commits May 15, 2024 16:17

Added a text input that only accepts full numbers (int)

6d4a0d9

Added to Gui sdk_headers and api_symbols in f7 and f18

9500df3

Changed name & added example fap

ac12e5f

Minor clenaup

ef2c36e

update for clearing views

c76c5f0

GUI: Fix array out of bounds in menu exit (flipperdevices#3604)

dd30f2b

* GUI: Fix array out of bounds in menu exit * Gui: fix incorrect empty menu handling * Gui: add missing item check in menu ok handling * Gui: remove dead code from menu module Co-authored-by: あく <alleteam@gmail.com>

nfc app: add legacy keys for plantain cards (flipperdevices#3602)

2058b2c

Co-authored-by: あく <alleteam@gmail.com>

rebase dev

0b3a8a1

leedave force-pushed the leedave/int_text_input branch from 77c0529 to 0b3a8a1 Compare May 15, 2024 14:43

David Lee and others added 14 commits May 15, 2024 16:51

Resolve conflict

b0799e8

Merge branch 'dev' into leedave/int_text_input

84038a2

refactoring test app, part 1

38f38b4

Refactor test app, part 2

beaf722

Minor updates while travelling

e0ab99d

Switched from const char to FuriString. Using Temp module copy for de…

327ac9c

…velopment to spare compile time

Option to limit number output with min and max values

fbc2a26

Preparations for option to change number sign from + to -

8bab4e1

Preparations for option to change number sign from + to -

243be0f

Merge branch 'dev' into leedave/int_text_input

6f4bc1f

Preparing for testing

85803fa

Merge branch 'dev' into leedave/int_text_input

c030692

counter automatic API version change

b08a742

fbt format

36d0d93

leedave marked this pull request as ready for review May 17, 2024 21:28

David Lee and others added 2 commits May 17, 2024 23:32

added trailing comma in application.fam ... because the lint check wa…

c472794

…nts it¿

Merge branch 'dev' into leedave/int_text_input

fe74f3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a text input that only accepts full numbers (int) #3350

Added a text input that only accepts full numbers (int) #3350

leedave commented Jan 9, 2024

hedger left a comment

leedave commented Jan 9, 2024

leedave commented Jan 11, 2024

skotopes commented Feb 15, 2024

leedave commented Feb 15, 2024

leedave commented Feb 15, 2024

skotopes commented Feb 16, 2024

skotopes Feb 16, 2024

skotopes Feb 16, 2024

skotopes commented Feb 16, 2024

skotopes commented Feb 16, 2024

skotopes commented Apr 19, 2024

leedave commented Apr 19, 2024

skotopes commented Apr 19, 2024

leedave commented Apr 19, 2024

leedave commented May 17, 2024

Added a text input that only accepts full numbers (int) #3350

Are you sure you want to change the base?

Added a text input that only accepts full numbers (int) #3350

Conversation

leedave commented Jan 9, 2024

What's new

Verification

Checklist (For Reviewer)

hedger left a comment

Choose a reason for hiding this comment

leedave commented Jan 9, 2024

leedave commented Jan 11, 2024

skotopes commented Feb 15, 2024

leedave commented Feb 15, 2024

leedave commented Feb 15, 2024

skotopes commented Feb 16, 2024

skotopes Feb 16, 2024

Choose a reason for hiding this comment

skotopes Feb 16, 2024

Choose a reason for hiding this comment

skotopes commented Feb 16, 2024

skotopes commented Feb 16, 2024

skotopes commented Apr 19, 2024

leedave commented Apr 19, 2024

skotopes commented Apr 19, 2024

leedave commented Apr 19, 2024

leedave commented May 17, 2024