Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dracula #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eleanor-clifford
Copy link

@eleanor-clifford eleanor-clifford commented Feb 1, 2021

The dracula theme required variables defined in another file. With these changes the variables are defined properly and the theme is fixed.

Fixes #178

@stefanbuettner
Copy link

This fix works for me. Thanks

@benknoble
Copy link

benknoble commented Jun 5, 2021

dracula/vim maintainer here; another option would be to actually use vim8's packs. This repo could be a "package", and each colorscheme could have its own directory (git submodules, if you like that?).

At any rate, better would be to keep all the files from a particular colorscheme… as this issue + PR indicates, things can break when you ignore certain files.

@eleanor-clifford
Copy link
Author

I agree, and using submodules would also make it easier to update the themes in this repository as they change upstream. @flazz seems pretty inactive though, I don't think this repo will be updated any time soon.

@EvitanRelta
Copy link

I've made a fork with a few colorschemes (including dracula) updated by via submodules and a script to add the /autoload files into the /colors/[name].vim file:
https://github.com/EvitanRelta/vim-colorschemes

Hopefully it'd be easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorscheme dracula cannot work
4 participants