Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.freedesktop.Sdk.Extension.fish #5248

Open
wants to merge 2 commits into
base: new-pr
Choose a base branch
from

Conversation

mdmundo
Copy link

@mdmundo mdmundo commented May 16, 2024

fish

The user-friendly command line shell as a freedesktop SDK extension

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.): no patches
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed. do not apply, it is an SDK extension.

flathub.json Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

hfiguiere commented May 16, 2024

I don't think a shell is appropriate as an Sdk extension.

@hfiguiere
Copy link
Contributor

And

Please describe your application briefly.

You didn't

@mdmundo
Copy link
Author

mdmundo commented May 16, 2024

Could be described as The user-friendly command line shell as a freedesktop SDK extension

I don't think a shell is appropriate as an Sdk extension.

It would be useful for some, as you can see here.

@mdmundo
Copy link
Author

mdmundo commented May 16, 2024

The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

@hfiguiere does this task apply here, since it is an sdk extension?

@mdmundo mdmundo marked this pull request as ready for review May 16, 2024 17:58
@faho
Copy link

faho commented May 16, 2024

Speaking as a fish developer:

I foresee support headaches for a flatpak, and I would prefer if it were not added by someone unaffiliated with the project.

We've thought about a flatpak (and a snap), but so far they haven't seemed appropriate for a shell (which can't really be sandboxed).

Of course I do note that the license allows anyone to do this, but as a courtesy I would prefer it not be merged.

@bbhtt bbhtt added the blocked Pull requests that are blocked on something or won't be accepted in the currrent state label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants