-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add net.casimirlab.frigoligo #5247
base: new-pr
Are you sure you want to change the base?
Conversation
- cp net.casimirlab.frigoligo.metainfo.xml /app/share/metainfo/ | ||
sources: | ||
- type: file | ||
url: https://github.com/casimir/frigoligo/releases/download/v1.0.10/frigoligo-v1.0.10-linux-x64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how will that work on aarch64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. I though the following lines prevent this case.
flathub/net.casimirlab.frigoligo.yml
Lines 19 to 20 in e75f33e
only-arches: | |
- x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the documentation says, this will just skip the module. An aarch64 flathub is still built.
It's also disappointing for aarch64 users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misunderstood the documentation then and that was not the intention. I can't find anything about architecture support, is it mandatory to support both x86_64
and aarch64
?
net.casimirlab.frigoligo.desktop
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be upstream
@@ -0,0 +1,46 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<component type="desktop-application"> | |||
<id>net.casimirlab.frigoligo</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
casimirlab.net
doesn't see to exist as a domain
yet:
[x] The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't expect a review so quickly, the configuration took some time to propagate.
$ curl -I frigoligo.casimirlab.net
HTTP/1.1 302 Moved Temporarily
server: nginx
date: Thu, 16 May 2024 12:40:12 GMT
content-type: text/html
content-length: 138
location: https://github.com/casimir/frigoligo
x-iplb-request-id: 50D79667:0F3E_D5BA2105:0050_6645FEAC_A584DD5E:3515
x-iplb-instance: 52345
set-cookie: SERVERID77446=200172|ZkX+r|ZkX+r; path=/; HttpOnly
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Please confirm your submission meets all the criteria