Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net.casimirlab.frigoligo #5247

Open
wants to merge 4 commits into
base: new-pr
Choose a base branch
from

Conversation

casimir
Copy link

@casimir casimir commented May 16, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

Frigoligo is a wallabag client crafted using Flutter. Its core philosophy is to prioritize pragmatism and adhering to best practices when it makes sense.

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://github.com/casimir/frigoligo/graphs/contributors
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

- cp net.casimirlab.frigoligo.metainfo.xml /app/share/metainfo/
sources:
- type: file
url: https://github.com/casimir/frigoligo/releases/download/v1.0.10/frigoligo-v1.0.10-linux-x64.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so how will that work on aarch64?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't. I though the following lines prevent this case.

only-arches:
- x86_64

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the documentation says, this will just skip the module. An aarch64 flathub is still built.

It's also disappointing for aarch64 users.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the documentation then and that was not the intention. I can't find anything about architecture support, is it mandatory to support both x86_64 and aarch64?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be upstream.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be upstream

@@ -0,0 +1,46 @@
<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop-application">
<id>net.casimirlab.frigoligo</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casimirlab.net doesn't see to exist as a domain

yet:

[x] The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

Copy link
Author

@casimir casimir May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect a review so quickly, the configuration took some time to propagate.

$ curl -I frigoligo.casimirlab.net                                                                                                                                                                                                                                                                                                    
HTTP/1.1 302 Moved Temporarily
server: nginx
date: Thu, 16 May 2024 12:40:12 GMT
content-type: text/html
content-length: 138
location: https://github.com/casimir/frigoligo
x-iplb-request-id: 50D79667:0F3E_D5BA2105:0050_6645FEAC_A584DD5E:3515
x-iplb-instance: 52345
set-cookie: SERVERID77446=200172|ZkX+r|ZkX+r; path=/; HttpOnly

@hfiguiere hfiguiere added awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels May 16, 2024
casimir and others added 3 commits May 16, 2024 14:56
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants