-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add io.github.milkshiift.GoofCord #5238
Conversation
Comments in the manifest explain the non-standard permissions |
io.github.milkshiift.GoofCord.yml
Outdated
url-query: .download_url | ||
|
||
- type: file | ||
url: https://github.com/Milkshiift/GoofCord/releases/latest/download/GoofCord-1.4.1-linux-x86_64.AppImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not rebuilding from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Vesktop's and ArmCord's flatpaks as a base, which unpack an AppImage. Is there a benefit to building from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if you can, always build from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoofCord uses Node >21 and pnpm which seem to not be available in flatpak. Building from source also seems like a mostly pointless over-complication that will make maintaining harder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also help with that.
bot, build io.github.milkshiift.GoofCord |
Queued test build for io.github.milkshiift.GoofCord. |
Started test build 120389 |
Build 120389 failed |
bot, build io.github.milkshiift.GoofCord |
Queued test build for io.github.milkshiift.GoofCord. |
Started test build 121921 |
Build 121921 successful
|
Fixed |
bot, build io.github.milkshiift.GoofCord |
Queued test build for io.github.milkshiift.GoofCord. |
Started test build 122017 |
Build 122017 successful
|
Tray works but it crashes now
I'd suggest removing the various GPU flags and keep the default value (you can keep the ozone flag, the others are not needed for that) |
The flags are needed for hardware acceleration on some systems. I tweaked them a bit to hopefully improve compatibility. |
bot, build io.github.milkshiift.GoofCord |
Queued test build for io.github.milkshiift.GoofCord. |
Started test build 122489 |
Build 122489 successful
|
bot, build io.github.milkshiift.GoofCord |
Queued test build for io.github.milkshiift.GoofCord. |
Started test build 123308 |
Build 123308 successful
|
/merge |
A repository for this submission has been created: https://github.com/flathub/io.github.milkshiift.GoofCord You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you. Thanks! |
GoofCord is a custom Discord client
Please confirm your submission meets all the criteria