Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.milkshiift.GoofCord #5238

Closed
wants to merge 16 commits into from
Closed

Conversation

Milkshiift
Copy link

GoofCord is a custom Discord client

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@Milkshiift Milkshiift changed the title Goof cord Add io.github.milkshiift.GoofCord May 12, 2024
@Milkshiift
Copy link
Author

Comments in the manifest explain the non-standard permissions

flathub.json Outdated Show resolved Hide resolved
minerals/startgoofcord Outdated Show resolved Hide resolved
url-query: .download_url

- type: file
url: https://github.com/Milkshiift/GoofCord/releases/latest/download/GoofCord-1.4.1-linux-x86_64.AppImage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not rebuilding from source?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used Vesktop's and ArmCord's flatpaks as a base, which unpack an AppImage. Is there a benefit to building from source?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if you can, always build from source.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoofCord uses Node >21 and pnpm which seem to not be available in flatpak. Building from source also seems like a mostly pointless over-complication that will make maintaining harder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also help with that.

@hfiguiere
Copy link
Contributor

bot, build io.github.milkshiift.GoofCord

@flathubbot
Copy link

Queued test build for io.github.milkshiift.GoofCord.

@flathubbot
Copy link

Started test build 120389

@flathubbot
Copy link

Build 120389 failed

@hfiguiere hfiguiere added the awaiting-changes Pull request waiting for changes from author label May 13, 2024
@Milkshiift
Copy link
Author

bot, build io.github.milkshiift.GoofCord

@flathubbot
Copy link

Queued test build for io.github.milkshiift.GoofCord.

@flathubbot
Copy link

Started test build 121921

@flathubbot
Copy link

Build 121921 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104866/io.github.milkshiift.GoofCord.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

Tray has no icon on GNOME (with the Appindicator extension)

image

@Milkshiift
Copy link
Author

Fixed

@Milkshiift
Copy link
Author

bot, build io.github.milkshiift.GoofCord

@flathubbot
Copy link

Queued test build for io.github.milkshiift.GoofCord.

@flathubbot
Copy link

Started test build 122017

@flathubbot
Copy link

Build 122017 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104961/io.github.milkshiift.GoofCord.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented May 20, 2024

Tray works but it crashes now

[Mod loader] Downloading mod bundle
GoofCord fully loaded in: 890.859ms
[52:0520/065112.350912:ERROR:gbm_pixmap_wayland.cc(82)] Cannot create bo with format= YUV_420_BIPLANAR and usage=GPU_READ_CPU_READ_WRITE

I'd suggest removing the various GPU flags and keep the default value (you can keep the ozone flag, the others are not needed for that)

startgoofcord Outdated Show resolved Hide resolved
@Milkshiift
Copy link
Author

Tray works but it crashes now

[Mod loader] Downloading mod bundle
GoofCord fully loaded in: 890.859ms
[52:0520/065112.350912:ERROR:gbm_pixmap_wayland.cc(82)] Cannot create bo with format= YUV_420_BIPLANAR and usage=GPU_READ_CPU_READ_WRITE

I'd suggest removing the various GPU flags and keep the default value (you can keep the ozone flag, the others are not needed for that)

The flags are needed for hardware acceleration on some systems. I tweaked them a bit to hopefully improve compatibility.
If it still doesn't work (I can't replicate the issue), and If it's not too much of a bother, can you test what flag(s) cause the problem?

@Milkshiift
Copy link
Author

bot, build io.github.milkshiift.GoofCord

@flathubbot
Copy link

Queued test build for io.github.milkshiift.GoofCord.

@flathubbot
Copy link

Started test build 122489

@flathubbot
Copy link

Build 122489 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105429/io.github.milkshiift.GoofCord.flatpakref

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 21, 2024
@barthalion
Copy link
Member

bot, build io.github.milkshiift.GoofCord

@flathubbot
Copy link

Queued test build for io.github.milkshiift.GoofCord.

@flathubbot
Copy link

Started test build 123308

@flathubbot
Copy link

Build 123308 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/106248/io.github.milkshiift.GoofCord.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/io.github.milkshiift.GoofCord

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants