Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.kde.sweeper #5231

Open
wants to merge 2 commits into
base: new-pr
Choose a base branch
from
Open

Add org.kde.sweeper #5231

wants to merge 2 commits into from

Conversation

Mailaender
Copy link

@Mailaender Mailaender commented May 10, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

Utility to clear caches

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: https://invent.kde.org/teams/flathub/issues/-/issues/14
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) https://invent.kde.org/utilities/sweeper/-/merge_requests/18

@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 119974

@flathubbot
Copy link

Build 119974 failed

@hfiguiere
Copy link
Contributor

cc @flathub/kde

org.kde.sweeper.json Outdated Show resolved Hide resolved
org.kde.sweeper.json Outdated Show resolved Hide resolved
@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120028

@flathubbot
Copy link

Build 120028 failed

@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120031

@flathubbot
Copy link

Build 120031 failed

@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120036

@flathubbot
Copy link

Build 120036 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102897/org.kde.sweeper.flatpakref

appstream.patch Show resolved Hide resolved
@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 11, 2024
@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120100

@flathubbot
Copy link

Build 120100 failed

appstream.patch Outdated Show resolved Hide resolved
@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120115

@flathubbot
Copy link

Build 120115 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102973/org.kde.sweeper.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented May 11, 2024

Looks good from my side waiting for a comment from KDE team.

@travier
Copy link
Member

travier commented May 13, 2024

Hum, doesn't this need full RW access to the home directory and all dot folders to be useful?

@Mailaender
Copy link
Author

I forgot to add a replacement for xdg-cache which was removed during review.

@Mailaender
Copy link
Author

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 120586

@flathubbot
Copy link

Build 120586 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/103446/org.kde.sweeper.flatpakref

@bbhtt bbhtt added awaiting-upstream Pull request waiting for changes from upstream and removed awaiting-changes Pull request waiting for changes from author labels May 27, 2024
@travier
Copy link
Member

travier commented May 29, 2024

bot, build org.kde.sweeper

@flathubbot
Copy link

Queued test build for org.kde.sweeper.

@flathubbot
Copy link

Started test build 124477

@flathubbot
Copy link

Build 124477 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/107437/org.kde.sweeper.flatpakref

@travier
Copy link
Member

travier commented May 29, 2024

Manifest LGTM and the app runs.

However I've not tried it yet as I don't know exactly what it removes and it has full home access so I will have to make backups before just to be safe here or run that in a VM.

@Mailaender
Copy link
Author

I am also unsure if it works at all because of the sandbox restrictions. Sounds like → beta to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Pull request waiting for changes from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants