Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.wwmm.easyeffects.Presets.LoudnessEqualizer #5227

Open
wants to merge 1 commit into
base: new-pr
Choose a base branch
from

Conversation

vchernin
Copy link

@vchernin vchernin commented May 9, 2024

Please confirm your submission meets all the criteria

Please also add @Digitalone1 as a collaborator for this repo.

This is the first "preset package" for Easy Effects. The idea is that users can install this package to make "presets" and their associated files available in Easy Effects. Right now users have to download various files straight from GitHub repos which is not the easiest unless you know how GitHub works. Some documentation meant for future packagers is here.

Note, currently this package cannot be fully tested without building from upstream master, most of the changes to add support for these packages have not been released (will be in 7.2.0). However, the Flathub package has already been changed to support the extension point since we need that to build this preset package, and the files are indeed mounted to the correct path.

Main possible issue here is what the name should be. Easy Effects on Flathub is com.github.wwmm.easyeffects. But since
com.github.* is not accepted for new submissions, these new packages use the extension point io.github.*. It is inconsistent and weird but works fine, I am not sure if it is worth EOL rebasing com.github.wwmm.easyeffects to io.github.wwmm.easyeffects .

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@vchernin
Copy link
Author

vchernin commented May 9, 2024

bot, build io.github.wwmm.easyeffects.Presets.LoudnessEqualizer

@flathubbot
Copy link

Queued test build for io.github.wwmm.easyeffects.Presets.LoudnessEqualizer.

@flathubbot
Copy link

Started test build 119847

@flathubbot
Copy link

Build 119847 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102699/io.github.wwmm.easyeffects.Presets.LoudnessEqualizer.flatpakref

@hfiguiere
Copy link
Contributor

Really, to install a few JSON files, this is

  1. overkill
  2. poor UX
  3. a lot of work

I don't think this is fit as a flatpak extension. You might as well ship it with the main package.

@vchernin
Copy link
Author

vchernin commented May 9, 2024

IMO it is somewhat overkill, but still useful especially for more complex presets. Some of the presets have additional IRS or RNNoise model files which are referenced by name in the json files and also need to be placed at the right path.

There is a decent variety of presets people have created over the years https://github.com/wwmm/easyeffects/wiki/Community-Presets. I don't think it would be very good to ship them all in the main package.

@Digitalone1
Copy link

Digitalone1 commented May 9, 2024

Really, to install a few JSON files, this is

  1. overkill
  2. poor UX
  3. a lot of work

I don't think this is fit as a flatpak extension. You might as well ship it with the main package.

Hello. How do you know they are "few" files? If these will be converted, I don't see them few.

And no, EasyEffects was not designed to ship presets. If someone makes presets for a specific device which I'm not interested, why should I be forced to have them in the main package?

@bbhtt bbhtt added the blocked Pull requests that are blocked on something or won't be accepted in the currrent state label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants