Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.bruttazz.FirefoxDevFlatpak #5175

Open
wants to merge 1 commit into
base: new-pr
Choose a base branch
from

Conversation

bRuttaZz
Copy link

@bRuttaZz bRuttaZz commented Apr 20, 2024

Firefox Dev Flatpak

It's is an unofficial flatpak packaging of Mozilla Firefox Developer Edition. Mozilla Firefox Developer Edition is a pre-beta release of Mozilla Firefox intended for Web developers and enthusiasts who want early access to new features. It receives new updates frequently, adding and refining support for the very latest Web standards that won't make it into the stable release of Firefox for some months. It also comes with some addons for Web development enabled by default.

This submission meets most of the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)


build-options:
build-args:
- --share=network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not allowed and will not work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's just a build arg right??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what don't you understand by "this is not allowed and will not work"?

# Intended to get the latest build from firefox (the 'source' functionality won't work if we didn't specify a checksum :)
# neither the fiefox archive supports 'latest' tag (https://archive.mozilla.org/pub/devedition/releases)
# raise a pr if you managed to find a better way
- wget -O firefox.tar.bz2 'https://download.mozilla.org/download/en-US/?product=firefox-devedition-latest-ssl&os=linux64&lang=en-US'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build MUST be done offline. This will not work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! sure, will make a script then..

# yes i didn't got any SVG (what if some syste going to identify it as a good thing 🫢, that's why the follwoing line)
- >
cp "$FLATPAK_DEST/opt/firefox/browser/chrome/icons/default/default128.png"
"$FLATPAK_DEST/share/icons/hicolor/scalable/apps/io.github.bruttazz.FirefoxDevFlatpak.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you lying claiming a PNG is scalable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought in some use cases the system will only look for icons under scalable. So..

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is acceptable given how Firefox flatpak is packaged.

@@ -0,0 +1,92 @@
id: io.github.bruttazz.FirefoxDevFlatpak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this app id is unlikely to be acceptable for a Firefox package. This is clearly not "under the control of upstream developers".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest which, base I should give. I mean, I'm not sure whether or not I can use their domain

@bbhtt bbhtt added awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels Apr 21, 2024
@barthalion
Copy link
Member

The only way forward with this is joining #flatpaks channel on the Mozilla Matrix server, and figuring out how to integrate developer edition with the upstream CI.

@barthalion
Copy link
Member

Just to clarify, Mozilla is definitely interested in getting this implemented, just don't have the resources themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants