-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add io.github.bruttazz.FirefoxDevFlatpak #5175
base: new-pr
Are you sure you want to change the base?
Add io.github.bruttazz.FirefoxDevFlatpak #5175
Conversation
|
||
build-options: | ||
build-args: | ||
- --share=network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not allowed and will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's just a build arg right??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what don't you understand by "this is not allowed and will not work"?
# Intended to get the latest build from firefox (the 'source' functionality won't work if we didn't specify a checksum :) | ||
# neither the fiefox archive supports 'latest' tag (https://archive.mozilla.org/pub/devedition/releases) | ||
# raise a pr if you managed to find a better way | ||
- wget -O firefox.tar.bz2 'https://download.mozilla.org/download/en-US/?product=firefox-devedition-latest-ssl&os=linux64&lang=en-US' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build MUST be done offline. This will not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! sure, will make a script then..
# yes i didn't got any SVG (what if some syste going to identify it as a good thing 🫢, that's why the follwoing line) | ||
- > | ||
cp "$FLATPAK_DEST/opt/firefox/browser/chrome/icons/default/default128.png" | ||
"$FLATPAK_DEST/share/icons/hicolor/scalable/apps/io.github.bruttazz.FirefoxDevFlatpak.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you lying claiming a PNG is scalable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I thought in some use cases the system will only look for icons under scalable. So..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this is acceptable given how Firefox flatpak is packaged.
@@ -0,0 +1,92 @@ | |||
id: io.github.bruttazz.FirefoxDevFlatpak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this app id is unlikely to be acceptable for a Firefox package. This is clearly not "under the control of upstream developers".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest which, base I should give. I mean, I'm not sure whether or not I can use their domain
The only way forward with this is joining #flatpaks channel on the Mozilla Matrix server, and figuring out how to integrate developer edition with the upstream CI. |
Just to clarify, Mozilla is definitely interested in getting this implemented, just don't have the resources themselves. |
Firefox Dev Flatpak
It's is an unofficial flatpak packaging of Mozilla Firefox Developer Edition. Mozilla Firefox Developer Edition is a pre-beta release of Mozilla Firefox intended for Web developers and enthusiasts who want early access to new features. It receives new updates frequently, adding and refining support for the very latest Web standards that won't make it into the stable release of Firefox for some months. It also comes with some addons for Web development enabled by default.
This submission meets most of the criteria