-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add io.github.chtholine.steganograpp #5170
base: new-pr
Are you sure you want to change the base?
Conversation
- install -D steganograpp/io.github.chtholine.steganograpp /app/bin/steganograpp | ||
sources: | ||
- type: file | ||
url: https://github.com/chtholine/steganograpp/raw/main/dist/io.github.chtholine.steganograpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to aarch64?
io.github.chtholine.steganograpp: ELF 64-bit LSB executable, x86-64, version 1 (SYSV)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also why did you upload a binary to git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I'm new to this and appreciate your assistance. I used PyInstaller to make an executable out of the python file with dependencies and decided to upload it. Should I do it other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You licensed it with GPL-3.0, so just build it here in the manifest and upload the source to the github repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also you never link from a branch but always from a commit.
- --socket=fallback-x11 | ||
- --socket=wayland | ||
- --share=ipc | ||
- --filesystem=host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need host?
buildsystem: simple | ||
build-commands: | ||
- chmod +x steganograpp/io.github.chtholine.steganograpp | ||
- install -D steganograpp/io.github.chtholine.steganograpp /app/bin/steganograpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing desktop file, metainfo file, icons etc.
This is missing
|
Please confirm your submission meets all the criteria
(Added "--filesystem=host" to work with images)