Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add io.github.chtholine.steganograpp #5170

Open
wants to merge 3 commits into
base: new-pr
Choose a base branch
from

Conversation

chtholine
Copy link

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
    (Added "--filesystem=host" to work with images)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@chtholine chtholine changed the title Steganograpp add io.github.chtholine.steganograpp Apr 17, 2024
- install -D steganograpp/io.github.chtholine.steganograpp /app/bin/steganograpp
sources:
- type: file
url: https://github.com/chtholine/steganograpp/raw/main/dist/io.github.chtholine.steganograpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to aarch64?

io.github.chtholine.steganograpp: ELF 64-bit LSB executable, x86-64, version 1 (SYSV)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why did you upload a binary to git?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I'm new to this and appreciate your assistance. I used PyInstaller to make an executable out of the python file with dependencies and decided to upload it. Should I do it other way?

Copy link
Contributor

@bbhtt bbhtt Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You licensed it with GPL-3.0, so just build it here in the manifest and upload the source to the github repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you never link from a branch but always from a commit.

- --socket=fallback-x11
- --socket=wayland
- --share=ipc
- --filesystem=host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need host?

buildsystem: simple
build-commands:
- chmod +x steganograpp/io.github.chtholine.steganograpp
- install -D steganograpp/io.github.chtholine.steganograpp /app/bin/steganograpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing desktop file, metainfo file, icons etc.

@bbhtt bbhtt added awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels Apr 17, 2024
@hfiguiere
Copy link
Contributor

This is missing

Please describe your application briefly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants