Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net.cachapa.tudo #5161

Open
wants to merge 1 commit into
base: new-pr
Choose a base branch
from
Open

Conversation

cachapa
Copy link

@cachapa cachapa commented Apr 14, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

Description: tudo is an experiment on simple, private, synchronized to-do lists.

Comment on lines +21 to +24
- type: dir
path: ../../build/linux/x64/release/bundle/
- type: dir
path: assets
Copy link
Contributor

@bbhtt bbhtt Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does this work? You should not use dir sources, it should be a direct link to the source code/tarball/binary etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest this is my first time generating a Flatpak so I'm not sure if my approach is correct.

In the first case, the directory contains the executable + precompiled libs required for the application to run.

In the second the assets directory contains metadata for the Flatpak: build script, icon, .desktop, etc.

Copy link
Contributor

@bbhtt bbhtt Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the directory contains the executable

And how is said directory found from here? We cannot go and grab it from your PC nor we can ship your PC.

It has to be a link.

@bbhtt bbhtt added awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels Apr 14, 2024
- name: tudo
buildsystem: simple
only-arches:
- x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also what happens with the aarch64 flatpak?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application only supports x86_64 at the moment.

My goal is to add aarch64 later once the x86_64 is published and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author blocked Pull requests that are blocked on something or won't be accepted in the currrent state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants