Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat.iamb.iamb #5110

Open
wants to merge 1 commit into
base: new-pr
Choose a base branch
from
Open

Add chat.iamb.iamb #5110

wants to merge 1 commit into from

Conversation

ulyssa
Copy link

@ulyssa ulyssa commented Mar 31, 2024

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
    • iamb is a terminal Matrix client that uses Vim keybindings
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions.
    • I have included permissions needed for the client to access the network, upload/download files, access the desktop clipboard, and talk with org.freedesktop.Notifications over dbus.
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub.
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
    • the website for iamb is iamb.chat, so I have made the ID chat.iamb.iamb.
  • Any additional patches or files have been submitted to the upstream projects concerned.
    • The iamb repo already includes a .desktop file and icon; the only extra files here are the metainfo for flathub, and a .cargo/config.toml to make cargo use the downloaded sources when using --offline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be upstream

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just clarify the myth: it is not flathub specific.


<screenshots>
<screenshot type="default">
<image>https://iamb.chat/static/images/iamb-demo.gif</image>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif won't likely work on the website can you png/jpgs?


<icon type="stock">chat.iamb.iamb</icon>
<launchable type="desktop-id">chat.iamb.iamb.desktop</launchable>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing content_rating, make sure to validate this file using https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#validation

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label Mar 31, 2024
</p>
</description>

<icon type="stock">chat.iamb.iamb</icon>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<icon type="stock">chat.iamb.iamb</icon>

don't use stock icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants