Add ability to upgrade plugin settings without a full reinstall cycle #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh4nks
reviewed
Feb 19, 2019
justanr
commented
Jul 3, 2019
| if key not in self.values | ||
| ] | ||
| # but what do here? | ||
| # updated_settings = [] |
There was a problem hiding this comment.
@sh4nks did we ever come up with a plan for updated settings? Still not sure what approach is best tbh
There was a problem hiding this comment.
Nope not really, IIRC we talked about versioning the settings but I am not exactly sure how this would solve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early Feedback for #508
Currently only covers the upgrade portion, though I have open questions on individually upgraded settings -- some things are trivial display name, description, default, are easy to reconcile as the underlying data doesn't change, but change in extras or value type could bork things. We might consider adding a "deprecated" to the settings object that accepts a version string for when the setting will be removed and not allow changing the value type (just ignore it, I guess? no sense in punishing users, but then again that could result in a broken upgrade).
Still working out what the hooks look like, but those'll be inbound by next weekend (assuming nothing comes up with work).