fix for #936 #937
Open
fix for #936 #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
reviewed
Mar 30, 2022
flask_restful/reqparse.py
Outdated
| @@ -122,6 +122,8 @@ def source(self, request): | |||
| else: | |||
| values = MultiDict() | |||
| for l in self.location: | |||
| if not request.is_json and l == 'json': | |||
There was a problem hiding this comment.
Switching the order of these checks is probably more efficient.
There was a problem hiding this comment.
Granted, re: your comment on the issue, this may be moot if maintenance has dropped off here, and we may need to look more closely at other options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue introduced with the release of Werkzeug 2.1, which no longer returns None when asked for JSON content on a request that does not have the Content-Type header set to "application/json".
Specifically, getattr() on line 125 in reqparse.py was looking for the default locations of json and values. This resulted in a call to json() in werkzeug.request, which in turn called get_json(). That method checks request.is_json, and now throws a BadRequest exception instead of returning None.
Here, I am proposing that flask-restful just perform the same check on request, and if the location is "json", skip it and move on.