roolback fl-log to glog #305
Conversation
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
9a1e6c0
to
cb18585
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
cb18585
to
68a9b5b
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
68a9b5b
to
9d5a76f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25349754 |
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
9d5a76f
to
fb1aaa5
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
fb1aaa5
to
1d5c4cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25349754 |
Summary: **IMPORTANT: Please do not create a Pull Request without creating an issue first.** Changes *must* be discussed. **Original Issue**: [corresponding issue on Github] *Note:* You can add `closes #[issue number]` to automatically close the issue that this PR resolves when it is merged. [Explain the details for this change and the problem that the pull request solves] ### Test Plan (required) [steps by which you tested that your fix resolves the issue. These might include specific commands and configurations] Pull Request resolved: flashlight#305 Differential Revision: D25349754 Pulled By: avidov fbshipit-source-id: 060294b6708eb8d5a174b97b3d5a7bf5b2d7403c
Summary: Pull Request resolved: flashlight#305 Rollback from FL_LOG to GLOG for flashlight/apps Differential Revision: D25349754 fbshipit-source-id: 28209e8255e39a6692365dd16b4330b959cbb246
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
1d5c4cb
to
17ae944
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25349754 |
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
Summary: **IMPORTANT: Please do not create a Pull Request without creating an issue first.** Changes *must* be discussed. **Original Issue**: [corresponding issue on Github] *Note:* You can add `closes #[issue number]` to automatically close the issue that this PR resolves when it is merged. [Explain the details for this change and the problem that the pull request solves] ### Test Plan (required) [steps by which you tested that your fix resolves the issue. These might include specific commands and configurations] Pull Request resolved: flashlight#305 Differential Revision: D25349754 Pulled By: avidov fbshipit-source-id: c368f11879a3f0769166b48e02cfb7547c8dc833
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **IMPORTANT: Please do not create a Pull Request without creating an issue first.** Changes *must* be discussed. **Original Issue**: [corresponding issue on Github] *Note:* You can add `closes #[issue number]` to automatically close the issue that this PR resolves when it is merged. [Explain the details for this change and the problem that the pull request solves] ### Test Plan (required) [steps by which you tested that your fix resolves the issue. These might include specific commands and configurations] Pull Request resolved: flashlight#305 Reviewed By: tlikhomanenko Differential Revision: D25349754 Pulled By: avidov fbshipit-source-id: bff1ca4dab83cd27cfb7aa8be5d733687ef4d996
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
17ae944
to
9bf23ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25349754 |
Summary: **IMPORTANT: Please do not create a Pull Request without creating an issue first.** Changes *must* be discussed. **Original Issue**: [corresponding issue on Github] *Note:* You can add `closes #[issue number]` to automatically close the issue that this PR resolves when it is merged. [Explain the details for this change and the problem that the pull request solves] ### Test Plan (required) [steps by which you tested that your fix resolves the issue. These might include specific commands and configurations] Pull Request resolved: flashlight#305 Reviewed By: tlikhomanenko Differential Revision: D25349754 Pulled By: avidov fbshipit-source-id: 73ab55b54ea62cd8ecc8545024881eead898fdff
|
This pull request was exported from Phabricator. Differential Revision: D25349754 |
avidov
force-pushed
the
gilad-flog-2-glog
branch
from
9bf23ae
to
b3c432f
Compare
|
@avidov has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@avidov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hi @avidov! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
IMPORTANT: Please do not create a Pull Request without creating an issue first. Changes must be discussed.
Original Issue: [corresponding issue on Github]
Note: You can add
closes #[issue number]to automatically close the issue that this PR resolves when it is merged.Summary
[Explain the details for this change and the problem that the pull request solves]
Test Plan (required)
[steps by which you tested that your fix resolves the issue. These might include specific commands and configurations]