Start Porting Shumai Tests #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: See title. Improves build time for most pkgs, especially since `runtime` depends on FL text as it stands Pull Request resolved: flashlight#1125 Test Plan: CI + local test Reviewed By: bwasti Differential Revision: D46469489 Pulled By: jacobkahn fbshipit-source-id: 3b86bd31472d414d52d0d7019c4c9d4521e85d84
Summary: See title. [[context](https://fb.workplace.com/groups/osssupport/posts/24783945017894113/)] Pull Request resolved: flashlight#1126 Test Plan: CI Reviewed By: bigfootjon Differential Revision: D46531543 Pulled By: jacobkahn fbshipit-source-id: 5e8e8040ee2beeca36cc831766527d283d9320fd
…t#1127) Summary: Switching to `macos.m1.medium.gen1` seems to result in OOM/infrastructure fails by default. Reduce build parallelism from CMake's high default to mitigate this Pull Request resolved: flashlight#1127 Test Plan: CI Reviewed By: bigfootjon Differential Revision: D46539373 Pulled By: jacobkahn fbshipit-source-id: ef14f7762b9fb817e0e44c5c27f42eae2c9d0c30
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: N/A
Summary
Starting work to port unit tests from shumai -> flashlight. So far have ported
any,all,cumsum,argmin, andargmax.Test Plan (required)
N/A as this is just adding more test coverage, not implementing new features.