feat: add support for SQLite
#3984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested changes
May 5, 2024
| throw new InvalidArgumentException('Only MySQL connections are supported'); | ||
| $doctrine = $connection->getDoctrineConnection()->getDatabasePlatform(); | ||
|
|
||
| if (! Type::hasType('timestamp')) { |
There was a problem hiding this comment.
fixes timestamp columns on sqlite migrations. (fails with an error otherwise)
| $pdo = (new MySqlConnector)->connect($config); | ||
|
|
||
| $version = $pdo->query('SELECT VERSION()')->fetchColumn(); | ||
|
|
||
| if (Str::contains($version, 'MariaDB')) { | ||
| if (version_compare($version, '10.0.5', '<')) { | ||
| if (version_compare($version, '10.10.0', '<')) { | ||
| throw new RangeException('MariaDB version too low. You need at least MariaDB 10.0.5'); |
There was a problem hiding this comment.
Should this message be adjusted to match the code?
Done in the pgsql branch
|
jaggy
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the roadmap
Changes proposed in this pull request:
Adds support for installing and using Flarum with SQLite 3.8.8+
While it is trivial to support it from core (apart from a couple exceptions where queries needed to be adapted), whether third party extensions will work with sqlite is a different matter. So I've added a warning about that on the installation page.
Screenshot
Necessity
Confirmed
composer test).Required changes: