Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ItemList component #3928

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

feat: ItemList component #3928

wants to merge 1 commit into from

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 10, 2023

Changes proposed in this pull request:

  • Introduces an ItemList component to simplify the way we define itemlists while maintaining a more readable structure.
  • If we decide to replace the component item lists in he code-base with this, it would be a major breaking change.
  • We do have an auto upgrade tool planned so it won't be as bad if we maintain the same references to the item lists, namely Component.methodName as item list key.

Reviewers should focus on:

  • Would we be alright with auto injecting context={this} using the webpack configuration?

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 10, 2023 13:21
@SychO9
Copy link
Member Author

SychO9 commented Nov 10, 2023

@clarkwinkelmann would love to get your opinion on this one if and when you get the chance 🙏🏼

Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one remark. Seems good to go.

Comment on lines +43 to +46

&-main {
height: 100%;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes necessary in this pr? Seems unrelated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants