Fix update cis #3587
Open
Fix update cis #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saibamen
suggested changes
Apr 29, 2024
| @@ -555,7 +563,7 @@ jobs: | |||
| echo "================================" | |||
| echo "VERSION=${last_committed_tag:1}" >> $GITHUB_ENV | |||
| - name: Packaging snap | |||
| uses: snapcore/action-build@v1 | |||
| uses: snapcore/action-build@v1.2.0 | |||
There was a problem hiding this comment.
Suggested change
| uses: snapcore/action-build@v1.2.0 | |
| uses: snapcore/action-build@v1 |
v1 will install latest v1 version ;)
| @@ -84,7 +90,7 @@ jobs: | |||
| echo "VERSION=$(cat CMakeLists.txt |grep 'set.*(.*FLAMESHOT_VERSION' | sed 's/[^0-9.]*//' |sed 's/)//g')" >> $GITHUB_ENV | |||
|
|
|||
| - name: Restore from cache and run vcpkg | |||
| uses: lukka/run-vcpkg@v11 | |||
| uses: lukka/run-vcpkg@v11.5 | |||
There was a problem hiding this comment.
Suggested change
| uses: lukka/run-vcpkg@v11.5 | |
| uses: lukka/run-vcpkg@v11 |
| with: | ||
| path: ./build/Qt/${{ matrix.qt_ver }}/${{ matrix.config.qt_arch_install }} | ||
| key: ${{ runner.os }}-QtCache/${{ matrix.qt_ver }}/${{ matrix.config.qt_arch }} | ||
|
|
||
| - name: Install Qt | ||
| uses: jurplel/install-qt-action@v2 | ||
| uses: jurplel/install-qt-action@v3.3.0 |
There was a problem hiding this comment.
Suggested change
| uses: jurplel/install-qt-action@v3.3.0 | |
| uses: jurplel/install-qt-action@v3 |
| with: | ||
| path: ./build/Qt | ||
| key: ${{ runner.os }}-QtCache | ||
|
|
||
| - name: Install Qt | ||
| uses: jurplel/install-qt-action@v2 | ||
| uses: jurplel/install-qt-action@v3.3.0 |
There was a problem hiding this comment.
Suggested change
| uses: jurplel/install-qt-action@v3.3.0 | |
| uses: jurplel/install-qt-action@v3 |
|
@Saibamen It is not clear in the Github documentation if there is a difference between In some workflows, they move their major version tag to the latest minor version (e.g Do you know how for example the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated everything to the latest minor or major version depending on if they have their major version tag following their latest stable minor version tag or not.
I have kept the
actions/upload-artifactback in v3 because:v3->v4(more info)