Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option where arrow can be drawn in a reveresed way #3477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lvhungdev
Copy link

@lvhungdev lvhungdev commented Jan 22, 2024

This PR attempts to fix #2144 where arrow can be drawn in a reversed way.
The head will be drawn first, the tail later.
This behavior can be toggled via configuration.

reversed-arrow

reversed-arrow.mp4

@lvhungdev lvhungdev changed the title Add new option where arrow can be drawn in a reveresed way. Fixed #2144 Add new option where arrow can be drawn in a reveresed way Jan 22, 2024
@lvhungdev lvhungdev marked this pull request as ready for review January 27, 2024 08:10
@lvhungdev
Copy link
Author

Hi. This PR has been sitting for a while without any updates. Am I missing something to get this PR reviewed?

@UnkwUsr
Copy link
Contributor

UnkwUsr commented Apr 28, 2024

Throwing random proposal for discussion:

Maybe it can toggle between default state by holding some key modifier, like alt or ctrl (instead of checkbox in settings) (but yes, then it is harder to find out about this feature even exists)?

@mmahmoudian
Copy link
Member

@lvhungdev Thanks for the PR. We are waiting for this PR to be approved. I generally support the idea and the PR but conventionally I will not attempt to merge code changes without approval of our C++ devs.

While we are here, would it be possible for you to add the Alt to toggle this on the fly? i mean whatever the setting/config is, the Alt flips the direction as long as Alt is pressed?

@UnkwUsr Thank you for the suggestion. I appreciate your input. I just want to point out that Ctrl is already is use. while drawing an arrow or line, holding Ctrl would snap the arrow to 45 degree angles. I believe the Alt is a better choice as also it "alters" the behavior :)

@mmahmoudian mmahmoudian added this to the v13 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting to draw arrows pointer first
3 participants