2023-12-05 Add new drawing tool 'LockPick' #3430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is only my 2nd ever gitHub submission (after practising with the 'first-contributions' project), so apologies for any rubbish.
I use Flameshot on a daily basis in my professional life (mainly for creating images of custom software for documentation, bug reports, etc) and I wanted what im describing as a "LockPick" but is really just a type of 'arrow', in the style that I've now created.
I checked the code for how the arrow worked and the graphics component seemed pretty simple, so i forked, copied the entire arrowTool but renamed it and gave it unique function names etc, tested, committed, pushed and am now asking for a 'Pull'.
Note: ive added the new icon to the far-right of the captureToolButton widget because, although its not with the other drawing tools (which would be the logical place to put it), I didnt want to interfere with other peoples muscle-memory of where to find the various buttons. Im happy for this to be moved around though if some underlying design principle requires it 馃憤
Thanks muchly,
Hugo