Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] added randomize pixels function to pixelate tool #3368

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kurayami07734
Copy link

Fixes #3289

Concerns

Pixelate tool's look changes completely. It now looks like white noise

Changes

  • Added a randomize pixels function to pixelate tool
  • Utilized random_shuffle from <algorithm> and memcpy from <cstring>

Results of cursory test

before

lorem before

after

lorem after

@mmahmoudian
Copy link
Member

mmahmoudian commented Oct 9, 2023

@kurayami07734 Thanks for the great work. Is it possible to:

  1. change the pixel size in accordance to the tool size that the user is using?
  2. considering that its a drastic change, can you add an item in the settings that allow the user to toggle this on/off? This is good for privacy, but it now looks like an extra opaque layer. This may cause backlash from users.

@kurayami07734
Copy link
Author

kurayami07734 commented Oct 10, 2023

change the pixel size in accordance to the tool size that the user is using?

I did not find where exactly the pixel size is being set

considering that its a drastic change, can you add an item in the settings that allow the user to toggle this on/off? This is good for privacy, but it now looks like an extra opaque layer. This may cause backlash from users.

I tried to add a setting for this in my latest commit. I followed the example of other settings already present. I am some how getting a segfault now

QLayout: Attempting to add QLayout "" to SidePanelWidget "", which already has a layout

Edit

I've narrowed it down to QAbstractButton::setChecked(bool)
I am probably not using the connect function properly

@kurayami07734
Copy link
Author

Hey guys, you probably missed this PR

@veracioux
Copy link
Contributor

@kurayami07734 I'm reviewing your PR now. Sorry about the wait.

@nxmndr
Copy link

nxmndr commented May 16, 2024

Is it not the same issue as #2439, #3323, #3242 etc ?

The current blur tool can be set at max size by scrolling and I think the effect is very satisfying. I'd rather have it than these little dots (no offense). It may not be clear enough that the scroll can be used for size though.

@kurayami07734 kurayami07734 changed the title added randomize pixels function to pixelate tool [FEAT] added randomize pixels function to pixelate tool May 16, 2024
@kurayami07734
Copy link
Author

kurayami07734 commented May 16, 2024

Is it not the same issue as #2439, #3323, #3242 etc ?

The current blur tool can be set at max size by scrolling and I think the effect is very satisfying. I'd rather have it than these little dots (no offense). It may not be clear enough that the scroll can be used for size though.

I've randomized the pixel using std::random_shuffle, so it looks like white noise a bit.

Also, can I run flameshot from wsl?
I'm this error flameshot: error: Unable to connect via DBus

@nxmndr
Copy link

nxmndr commented May 16, 2024

Ah my bad it will be a separate toggle/option. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to obfuscate mosaics to avoid retrieving redacted text from mosaics
5 participants