[WIP] feat: add --iterations flags to specify how many times to run target binary #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Mar 8, 2023
| @@ -2,6 +2,12 @@ | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
|
|
|||
| [[package]] | |||
There was a problem hiding this comment.
These changes don't belong in this PR, please revert.
| @@ -316,7 +316,7 @@ fn print_command(cmd: &Command, verbose: bool) { | |||
| } | |||
| } | |||
|
|
|||
| pub fn generate_flamegraph_for_workload(workload: Workload, opts: Options) -> anyhow::Result<()> { | |||
| pub fn generate_flamegraph_for_workload(workload: Workload, opts: Options, iterations: usize) -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
I think it might make sense to store iterations inside Options?
|
|
||
| for _i in 0..iterations { | ||
| if let Workload::ReadPerf(_perf_file) = &workload { | ||
| // pass |
There was a problem hiding this comment.
Did you test this with a Workload::ReadPerf scenario? I guess maybe this if needs to be outside this loop, so that we can still pass perf_file to output() (as perf_output)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks for the great project, we use it extensively at Deno.
While we are working on improving our startup time, we found out that running the target binary just once is not enough to collect reliable data to see where we're spending time. So I added
--iterationsflag that allows to run target binary multiple times and create a single flamegraph out of all the runs.This is a quick a dirty implementation, but it allows us to collect more detailed data. If there's an interest in adding this flag and upstreaming the patch I'll be happy to clean it up.