Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use main lodash instead of lodash.throttle to make webpack bundles smaller #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jedwards1211
Copy link

fix #55

I also added babel-plugin-lodash so that there's low risk of anyone
importing additional lodash methods in an inefficient way in the future.
But if you want me to remove this and just use import throttle from 'lodash/throttle'
instead, let me know.

@jedwards1211 jedwards1211 changed the title fix: use main lodash instead of lodash.throttle fix: use main lodash instead of lodash.throttle to make webpack bundles smaller Aug 24, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.907% when pulling c8fd33f on jedwards1211:main-lodash into f4724fb on fkhadra:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import throttle from 'lodash/throttle' is actually better at reducing bundle size than 'lodash.throttle'
2 participants