Update int_netsuite2__transaction_lines.sql #88
Conversation
This will ensure that transactions are not duplicated downstream due to multiple accounting books.
|
@magoavi thanks for opening this PR! We have actually been seeing a number of requests lately around accounting books in Netsuite (#85 as an example). I do not have much experience with multi book accounting in Nestuite and would like to understand it in more detail. Would you be able to share why you are seeing duplicates in the current version of the package and how your suggested changes resolves this issue. Thanks! |
|
|
||
| where transaction_accounting_lines.accounting_book_id in (select accounting_book_id from accounting_books where is_primary) |
There was a problem hiding this comment.
I am a bit worried to directly apply this filter in this model. Could it still be worthwhile to include non primary accounting book accounts in downstream calculations? I wonder if it would be more appropriate to simply add the accounting book fields to these models and allow the end users to filter appropriately based on their needs. Thoughts?
There was a problem hiding this comment.
I agree with you @fivetran-joemarkiewicz. accounting_book_id is an important dimension in the transaction line data. This filter could be applied downstream in a production view if needed.
|
Hi @magoavi! We have just released a beta version that might be a solution for what you're trying to do. In this version, multibook (and packages:
- package: fivetran/netsuite
version: 0.12.0-b1If you try it out, let us know how it goes! |
This will ensure that transactions are not duplicated downstream due to multiple accounting books.
Avi Mago | Our Habitas
Link the issue/feature request which this PR is meant to address
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
How did you validate the changes introduced within this PR?
Which warehouse did you use to develop these changes?
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
馃拑
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)