RFC: Close Transactions On Daily Closing #211
Conversation
volllly
changed the title
| The method `CloseOpenTransactionsOnTseAsync` looks like this which is inspired by the current [Fail-Transaction Receipt](https://github.com/fiskaltrust/middleware/blob/1a9abd80430e9dfecdd17289024e9d19e798d19b/queue/src/fiskaltrust.Middleware.Localization.QueueDE/RequestCommands/FailTransactionReceiptCommand.cs#L64-L77). | ||
|
|
||
| ```cs | ||
| private CloseOpenTransactionsOnTseAsync(IEnumerable<long> currentStartedTransactionNumbers) |
There was a problem hiding this comment.
This only closes the open transactions of the current Queue, right (since transactionsToClose is not used, but the data from the _openTransactionsRepo)?
There was a problem hiding this comment.
I've clarified the code a bit. It should finish the transactions on the TSE and remove them from the open transactions in the queue.
|
|
||
| ## Closing foreign Transactions | ||
|
|
||
| If a TSE is used by multiple Queues the Transactions of open other Queues will be closed as well. |
There was a problem hiding this comment.
Might make sense to protocol in the actionjournal which transactions were closed 🤔 in one entry, not X :D
There was a problem hiding this comment.
Good idea. I've added pseudo code for that 🙏 I'm not sure though about the ActionJournal Type though
|
Def like this idea 👍🏻 should make things a lot easier, we should have done it that way from the very beginning indeed. |
We want to introduce a ftReceiptCaseFlag to the Daily-Closing that closes all open transactions on the TSE.
Rendered