Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate builtin test's one- and zero-argument modes #10365

Merged
merged 3 commits into from Apr 21, 2024
Merged

Deprecate builtin test's one- and zero-argument modes #10365

merged 3 commits into from Apr 21, 2024

Commits on Apr 12, 2024

  1. Introduce test-require-arg feature flag 

    This removes builtin test's zero and one argument special modes.

That means:

- `test -n` returns false
- `test -z` returns true
- `test -x` with any other option errors out with "missing argument"
- `test foo` errors out as expecting an option
    @faho
    faho committed Apr 12, 2024
    Copy the full SHA
    91a16bb View commit details
    Browse the repository at this point in the history

  2. Add deprecation warning 

    FLOG category "deprecated-test", run `fish -d deprecated-test` and it
will show any test call that would change in future.
    @faho
    faho committed Apr 12, 2024
    Copy the full SHA
    3dbffcc View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. document test-require-arg

    @faho
    faho committed Apr 13, 2024
    Copy the full SHA
    6a4b289 View commit details
    Browse the repository at this point in the history