Reimplement git version generation ourselves #10336
Conversation
This allows us to remove two dependency crates
|
I haven't had a chance to test, but does this do any better with dirty/non-dirty trees? The CMake/sh version always picked up if the tree was dirty, but the git-version.rs approach only worked if a Rust source file had been modified. |
|
@zanchey we would have to use rebuild_if_paths_changed and pass in all additional paths (share, mainly?) we want build.rs to be re-run if they change. This will mean slightly slower incremental builds after changing only fish files, but I think it shouldn't result in actual work for the compiler. |
| return var; | ||
| } | ||
|
|
||
| let path = PathBuf::from(build_dir).join("version"); |
There was a problem hiding this comment.
I would like to (at some point) rename this file to FISH_BUILD_VERSION to make everything more consistent.
There was a problem hiding this comment.
Tbh my preference would be to pass the version as an environment variable - this would also be much easier for sphinx to read when building manpages (which would allow us to build them before building the binaries, which makes it possible to embed them in a binary).
I haven't figured out how to get cmake to do that, tho
|
LGTM. I see no need for that dependency. |
This is basically the same thing as before. It's really mostly about not needing a dependency that we barely use, and partially about being able to adjust it just to our liking. Alright, merging, it's simple enough to revert if there are any issues. |
This allows us to remove two dependency crates