V2 #683
Open
V2 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Saunders <paul.saunders@finbourne.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This may or maynot pass the tests, since the changes should be backward compatible, but there's no gaurantee. |
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
developbranchDescription of the PR
This is a whole lotta change that makes the notebooks work with V2 of the python generated sdk; mostly for LUSID-sdk.
All the workbooks have been run, and checked.
Primarily the only changes required were to use
fbnsdkutilities, which required a small change to ApiClientFactory calls to pass in the sdk being used. Other notable changes were mostly just pandas removing theappendmethod from dataframes.