Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTECH-2596 Add the notebook for T09005 #655

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MikeMcGarry
Copy link
Member

Pull Request Checklist

  • Changes follow the style guide
  • Tests pass
  • Raised the PR against the develop branch

Description of the PR

Describe the code changes for the reviewers, explain the solution you have provided and how it fixes the issue

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MikeMcGarry
Copy link
Member Author

/LGTM

@@ -0,0 +1,465 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs explanation, or is it somewhere else?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah in the Finbourne University course. These notebooks are not intended to be standalone resources, rather they complement the FINBOURNE University course and are available here for re-recording/updating content. I intend for them to be exactly the same as what is shown in the course wherever possible, with only minor modifications to ensure that they can run in the CI pipeline successfully.

@MikeMcGarry
Copy link
Member Author

/LGTM

1 similar comment
@MikeMcGarry
Copy link
Member Author

/LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants