CTECH-2603 Added a notebook for T10003 Retrieving Files #642
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
/LGTM |
MikeMcGarry
force-pushed
the
feature/CTECH-2603
branch
from
11decd9
to
b8c14a7
Compare
|
/LGTM |
1 similar comment
|
/LGTM |
| @@ -0,0 +1,871 @@ | |||
| { | |||
There was a problem hiding this comment.
this example implies the file is available straight away, but i believe that may not be the case. we have extensions in the sdk to do the checking status so it appears as a synchronous call. i think we should either 1) explain and show how to do the checking status, or 2) use the sdk method. i appreciate that may not be in all the sdks but it does provide a place for a user to go and look at some code to see how to implement
Reply via ReviewNB
| @@ -0,0 +1,871 @@ | |||
| { | |||
There was a problem hiding this comment.
we might end up in a race condition where the nb runs in multiple pipelines, wrap this in a try-except?
Reply via ReviewNB
| @@ -0,0 +1,871 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #7. api_factory_notifications = ApiClientFactory(token=RefreshingToken())
why "notifications"?
Reply via ReviewNB
Pull Request Checklist
developbranchDescription of the PR
Describe the code changes for the reviewers, explain the solution you have provided and how it fixes the issue