Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/readsecrets + brief readme #6
base: master
Are you sure you want to change the base?
Feature/readsecrets + brief readme #6
Changes from 4 commits
e2bd89c
c71e92f
033358e
c9f9732
e6c7ac4
8e895b8
3220f70
923bc00
c37c1d8
158f1c8
ba45d72
dc50d15
0e890ba
970cc0f
6144dd0
7ff33c9
6656321
bc466bd
84c4f30
11b624a
ade1a80
d25862c
7ccd1f3
90ab2fc
1986cd1
581abff
de7e7b7
5a144d8
63a7fb0
2e7a030
d31c5ab
b310b89
38b4024
c44409f
abefcf1
d872778
bbb0e73
a226e38
3ef9303
c71e870
7da1325
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this client runs the tests we need some way to ensure that we can run them locally using a secrets file and in our continuous integration pipeline which will use environment variables.
The logic in the Python SDK is to use a secrets file if provided, falling back to environment variables if it can't find a secret file. Do you think we could implement similar logic here?
https://github.com/finbourne/lusid-sdk-python-preview/tree/master/sdk/lusid/utilities
I would suggest that this lives in the sdk/client/client.ts but then you can delete completely the commented out code which references environment variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. will do.