Fix submit func return type in typescript declaration #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gertdreyer sorry for pinging 馃槄 I'm not sure currently who is responsible for maintaining this project and just found out you're the recent reviewer of PRs like #473. Would you mind reviewing this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #368.
Currently this issue will cause all typescript users cannot rely on the type declaration of
FormApi['submit']. The return type ofFormApi['submit']is wrong: When submit is async, the value of Promise should beSubmissionErrors | undefined, notFormValues | undefined.Personally I found this error when I try to apply typescript in a project using final-form, and found out this brings a lot of tsc errors in codebase, which relies on returned submission errors heavily. Had to patch the fix in my project temporarily but not ideal.
@erikras it would be great if you could take a look for this one-line patch 馃檹
Also thanks @akozhemiakin raising #368 and suggest the fix 馃憤