Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialValues optionality in FormState TypeScript #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsonunger
Copy link

@jsonunger jsonunger commented Jan 20, 2023

The TypeScript type for initialValues in form state doesn't reflect the code. In the createForm method, the code initializes formState.initialValues with a short-circuit assignment. As a result, if a consumer calls createForm without any initial values, initialValues in form state will be undefined. Marking the field as optional in the types brings it inline with the code expectation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant