hotfix(exec) 0.9.25.7: remove possible RemoteExec deadlock cause #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
changed the title
alextheimer
changed the title
| val waitUntilMs = System.currentTimeMillis() + unit.toMillis(timeout) | ||
| // looping in case thread is woken up early | ||
| while (!_shutdown && System.currentTimeMillis() < waitUntilMs) { | ||
| val waitMs = waitUntilMs - System.currentTimeMillis() |
There was a problem hiding this comment.
This can possibly become negative between your checks and calculation and will end up with IllegalArgumentException
There was a problem hiding this comment.
Good catch -- I assumed wrongly that negative values were ignored. Updated ✅
| @@ -52,7 +52,7 @@ trait RemoteExec extends LeafExecPlan with StrictLogging { | |||
| val waitUntilMs = System.currentTimeMillis() + unit.toMillis(timeout) | |||
| // looping in case thread is woken up early | |||
| while (!_shutdown && System.currentTimeMillis() < waitUntilMs) { | |||
| val waitMs = waitUntilMs - System.currentTimeMillis() | |||
| val waitMs = Math.max(0, waitUntilMs - System.currentTimeMillis()) | |||
There was a problem hiding this comment.
If its 0, you want till you are notified, is that the expected behavior?
Just to clarify, if the value is positive, it will come out of waiting state, go check the while condition and go back to waiting state, but with 0 it will never come out of wait until notified.
|
Closed -- we can revisit this solution later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist