Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): Adding new helper method to get column filter list along with leaf plan #1762

Merged

Conversation

sandeep6189
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

New behavior : Adding new helper method to get column filter list along with leaf plan

@sandeep6189 sandeep6189 changed the title fix(misc): Adding new helper method to get column filter list along with leaf plan feat(misc): Adding new helper method to get column filter list along with leaf plan Apr 23, 2024
yu-shipit
yu-shipit previously approved these changes Apr 25, 2024
Copy link
Contributor

@yu-shipit yu-shipit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for adding the test cases.

@sandeep6189 sandeep6189 merged commit 90a05c2 into filodb:develop Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants