Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Updating Regex to support preagg metric names with column selector #1550

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

sandeep6189
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :

Streaming aggregation creates new metric names of the format {metric_name}:::{rule_name}. The current toLogicalPlan method incorrectly splits the aggregated metric name into a metric name and column name. For example, for following aggregated metric, where no column name is specified, the regex breaks the metric name into following:

  1. "http_requests_total:::aggregated_rule" --> metric_name: (http_requests_total:) column_name: (aggregated_rule)

New behavior : Fixed the regex used to accommodate this scenario

Copy link
Contributor

@sherali42 sherali42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sandeep6189 for taking this up 👍

@sandeep6189 sandeep6189 merged commit efbdd30 into filodb:develop Apr 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants