feat(query): namespace cardinality publisher #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
commented
Nov 30, 2021
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
alextheimer
commented
Nov 30, 2021
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
alextheimer
commented
Nov 30, 2021
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
alextheimer
commented
Nov 30, 2021
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
vishramachandran
requested changes
Dec 1, 2021
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/NamespaceCardinalityPublisher.scala
Outdated
Show resolved
Hide resolved
coordinator/src/main/scala/filodb.coordinator/ShardManager.scala
Outdated
Show resolved
Hide resolved
alextheimer
force-pushed
the
card-ts
branch
2 times, most recently
from
1dce982
to
1dd863b
Compare
alextheimer
force-pushed
the
card-ts
branch
2 times, most recently
from
8190b92
to
731d2ec
Compare
* use future.onComplete instead of queue * log query failures * kamon metrics renamed * class rename * kamon tags updated * instantiate TIM only if metering enabled in config * add TIM query delay to config * addl documentation
|
Rebased with the most recent |
|
2c73554 smuggles in a test that should have been included in the last PR |
vishramachandran
approved these changes
Dec 7, 2021
coordinator/src/main/scala/filodb.coordinator/TenantIngestionMetering.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
New behavior :
Adds a
TenantIngestionMeteringinstance to the leaderNodeCoordinatorActor(via theShardManager). This periodically queries aNodeCoordinatorActorfor namespace-level cardinality data, then it publishes the results asKamonmetrics.