logging statement for large cardinality queries #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjackpaul
reviewed
Jun 15, 2021
| if (recs.size > 100000) { | ||
| // if we have a 3 bit spread and one shard has more than 100K tss, it means | ||
| // that the cardinality of the query is ~800K close to a million, hence we want to log such queries | ||
| logger.warn(s"Number of tss: ${recs.size} for query ${querySession.qContext.origQueryParams}") |
There was a problem hiding this comment.
@kvpetrov is it also possible to add a toString override here https://github.com/filodb/FiloDB/blob/develop/core/src/main/scala/filodb.core/query/QueryContext.scala#L17 and convert it to a key=value pairs for better readability in logs for querySession.qContext.origQueryParams?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: