Update the React example to use functional component #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the class example to modernize the React best practices.
Removing the class example to modernize the React best practices.
shuta13
suggested changes
Jul 18, 2021
|
|
||
| declare function require(path: string): any | ||
|
|
||
| class App extends React.Component { | ||
| textbox: HTMLInputElement | ||
| const App = () => { |
There was a problem hiding this comment.
I think the following is better
Suggested change
| const App = () => { | |
| const App: React.FC = () => { |
| parent.postMessage({ pluginMessage: { type: 'create-rectangles', count } }, '*') | ||
| } | ||
|
|
||
| onCancel = () => { | ||
| const onCancel = () => { | ||
| parent.postMessage({ pluginMessage: { type: 'cancel' } }, '*') | ||
| } | ||
|
|
||
| render() { |
There was a problem hiding this comment.
I don't think the render() is necessary, just return should do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React example is using an outdated webpack file and React version.
This updates the component to use a functional definition, rather than the class. More improvements could be made.