Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace conditions with stripped conditions #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angi-
Copy link

@angi- angi- commented Mar 1, 2020

When using joins in the readQueryBuilder in the format table.column there's always an exception because both of the initial conditions and stripped conditions are passed to PDO.

This query

$readQueryBuilder = (new ReadQueryBuilder)
    ->addSelect('users.*')
    ->addSelect(profiles.nickname as user_nickname')
    ->addCondition('users.id', $userId)
    ->addInnerJoin('profiles', 'profiles', 'users.id = profiles.user_id');

will generate the following conditions:

[
    { "users.id": "35140057-a2a4-5adb-a500-46f8ed8b66a9" },
    { "usersid": "35140057-a2a4-5adb-a500-46f8ed8b66a9" }
]

which will throw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant