-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at fixing figure name in ft_sourceplot #2167
base: master
Are you sure you want to change the base?
Conversation
would it not be better to have the figure title always handled by Right now it appears from the ft_sourceplot code that - as an afterthought - someone added the lines at the end of the function that, based on dataname, update the figure title. |
Indeed, hence why I said this is a "sloppy" fix - that just fixes it exactly where the problem occurs right now |
cfg.figurename and cfg.dataname seem two options that aim at solving the same thing. It would be better to merge the functionality. |
this is a pointer in the direction of a fix ad58d6f I see the following options:
Whether a, b, c, should be optional or always used, I don't know |
just for your ft_sourceplot case: if you do this
just prior to Btw, this is me typing some code without trying it out. I am not sure about the |
Hi @britta-wstnr, have you tried the code suggestion I gave above? |
Hi @robertoostenveld no, I have not had the time yet to look at it again! |
As mentioned in #2166
cfg.figurename
inft_sourceplot
gets ignored as it gets set regardless of the presence of this field.This fixes it - but might be a bit sloppy as
cfg.figurename
does get passed toopen_figure
in the code above my fix - was not sure if it should rather get fixed there?CC @robertoostenveld