Octave compatibility for ft_compile_mex
#1036
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
ft_compile_mex
for Octave compatibility.Addresses #1027 (comment).
The big issue with Octave compatibility is that it picks up files inside
@class
directories when youcd
in to them and sees them as global functions. This PR restructuresft_compile_mex
to not change into the individual source directories when it's doing compiling. Also addresses differences in Octavemex()
's signature from Matlab'smex()
.With this change, everything is compiling on Octave 4.4.1 on macOS for me, except
mxSerialize
andmxDeserialize
.Looks like a problem with the MX API thing they're setting up in the defines.
It's not working on macOS for me under R2017b or R2018b because
mex
doesn't like the'CFLAGS=''-std=c99 -fPIC'''
argument.References