-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dropping omniauth due to CVE-2015-9284
https://github.com/fiedl/your_platform/network/alert/Gemfile.lock/omniauth/open omniauth/omniauth#960 omniauth/omniauth#809 I've subscribed to these issues to get notified when there is a fixed release. https://trello.com/c/Qgekdkea/1337
- Loading branch information
Showing
6 changed files
with
52 additions
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,30 @@ | ||
require 'omni_auth_provider' | ||
#require 'omni_auth_provider' | ||
# | ||
#Rails.application.config.middleware.use OmniAuth::Builder do | ||
# if OmniAuthProvider.github.available? | ||
# provider :github, | ||
# OmniAuthProvider.github.app_id, | ||
# OmniAuthProvider.github.app_secret, | ||
# scope: 'user:email' # https://developer.github.com/v3/oauth/#scopes | ||
# end | ||
# if OmniAuthProvider.twitter.available? | ||
# provider :twitter, | ||
# OmniAuthProvider.twitter.app_id, | ||
# OmniAuthProvider.twitter.app_secret | ||
# end | ||
# if OmniAuthProvider.google.available? | ||
# provider :google_oauth2, | ||
# OmniAuthProvider.google.app_id, | ||
# OmniAuthProvider.google.app_secret, | ||
# verify_iss: false # https://stackoverflow.com/a/45292982/2066546 | ||
# end | ||
# if OmniAuthProvider.facebook.available? | ||
# provider :facebook, | ||
# OmniAuthProvider.facebook.app_id, | ||
# OmniAuthProvider.facebook.app_secret, | ||
# scope: 'email' | ||
# end | ||
#end | ||
|
||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
if OmniAuthProvider.github.available? | ||
provider :github, | ||
OmniAuthProvider.github.app_id, | ||
OmniAuthProvider.github.app_secret, | ||
scope: 'user:email' # https://developer.github.com/v3/oauth/#scopes | ||
end | ||
if OmniAuthProvider.twitter.available? | ||
provider :twitter, | ||
OmniAuthProvider.twitter.app_id, | ||
OmniAuthProvider.twitter.app_secret | ||
end | ||
if OmniAuthProvider.google.available? | ||
provider :google_oauth2, | ||
OmniAuthProvider.google.app_id, | ||
OmniAuthProvider.google.app_secret, | ||
verify_iss: false # https://stackoverflow.com/a/45292982/2066546 | ||
end | ||
if OmniAuthProvider.facebook.available? | ||
provider :facebook, | ||
OmniAuthProvider.facebook.app_id, | ||
OmniAuthProvider.facebook.app_secret, | ||
scope: 'email' | ||
end | ||
end | ||
# dropped support for omniauth due to | ||
# https://github.com/fiedl/your_platform/network/alert/demo_app/my_platform/Gemfile.lock/omniauth/open |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01a91a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you are not replacing the functionality, simply removing it...
I don't think you should, the security warning looks more alarming than actually is