Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(ci): convert
.eslintrc.json
to yaml
- Loading branch information
Showing
2 changed files
with
196 additions
and
152 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,196 @@ | ||
extends: eslint:recommended | ||
parserOptions: | ||
ecmaVersion: 2017 | ||
ecmaFeatures: | ||
impliedStrict: true | ||
env: | ||
es6: true | ||
node: true | ||
mocha: false | ||
rules: | ||
no-await-in-loop: 'off' | ||
no-compare-neg-zero: error | ||
no-extra-parens: | ||
- warn | ||
- all | ||
- nestedBinaryExpressions: false | ||
no-template-curly-in-string: error | ||
no-unsafe-negation: error | ||
valid-jsdoc: | ||
- warn | ||
- prefer: | ||
arg: param | ||
return: returns | ||
preferType: | ||
Boolean: boolean | ||
Number: number | ||
object: Object | ||
String: string | ||
requireReturn: false | ||
requireReturnType: true | ||
requireParamDescription: false | ||
requireReturnDescription: false | ||
requireParamType: true | ||
accessor-pairs: warn | ||
array-callback-return: error | ||
complexity: | ||
- 'off' | ||
- max: 25 | ||
consistent-return: 'off' | ||
curly: | ||
- error | ||
- multi-line | ||
- consistent | ||
dot-location: | ||
- error | ||
- property | ||
dot-notation: error | ||
eqeqeq: error | ||
no-console: | ||
- error | ||
- allow: | ||
- warn | ||
no-empty-function: error | ||
no-floating-decimal: error | ||
no-implied-eval: error | ||
no-invalid-this: error | ||
no-lone-blocks: error | ||
no-multi-spaces: error | ||
no-new-func: error | ||
no-new-wrappers: error | ||
no-new: error | ||
no-octal-escape: error | ||
no-return-assign: 'off' | ||
no-return-await: error | ||
no-self-compare: error | ||
no-sequences: error | ||
no-throw-literal: error | ||
no-unmodified-loop-condition: error | ||
no-unused-expressions: error | ||
no-useless-call: error | ||
no-useless-concat: error | ||
no-useless-escape: error | ||
no-useless-return: error | ||
no-void: error | ||
no-warning-comments: warn | ||
prefer-promise-reject-errors: error | ||
require-await: warn | ||
wrap-iife: error | ||
yoda: error | ||
no-label-var: error | ||
no-shadow: error | ||
no-undef-init: error | ||
callback-return: error | ||
handle-callback-err: error | ||
no-mixed-requires: error | ||
no-new-require: error | ||
no-path-concat: error | ||
array-bracket-spacing: error | ||
block-spacing: error | ||
brace-style: | ||
- error | ||
- 1tbs | ||
- allowSingleLine: true | ||
capitalized-comments: | ||
- error | ||
- always | ||
- ignoreConsecutiveComments: true | ||
comma-dangle: | ||
- error | ||
- always-multiline | ||
comma-spacing: error | ||
comma-style: error | ||
computed-property-spacing: error | ||
consistent-this: | ||
- error | ||
- "$this" | ||
eol-last: error | ||
func-names: error | ||
func-name-matching: error | ||
func-style: | ||
- error | ||
- declaration | ||
- allowArrowFunctions: true | ||
indent: | ||
- error | ||
- 2 | ||
- SwitchCase: 1 | ||
key-spacing: error | ||
keyword-spacing: error | ||
max-depth: error | ||
max-len: | ||
- error | ||
- 120 | ||
- 2 | ||
max-nested-callbacks: | ||
- error | ||
- max: 4 | ||
max-statements-per-line: | ||
- error | ||
- max: 2 | ||
new-cap: 'off' | ||
newline-per-chained-call: | ||
- error | ||
- ignoreChainWithDepth: 3 | ||
no-array-constructor: error | ||
no-inline-comments: error | ||
no-lonely-if: error | ||
no-mixed-operators: error | ||
no-multiple-empty-lines: | ||
- error | ||
- max: 2 | ||
maxEOF: 1 | ||
maxBOF: 0 | ||
no-new-object: error | ||
no-spaced-func: error | ||
no-trailing-spaces: error | ||
no-unneeded-ternary: error | ||
no-whitespace-before-property: error | ||
nonblock-statement-body-position: error | ||
object-curly-spacing: | ||
- error | ||
- always | ||
operator-assignment: error | ||
operator-linebreak: | ||
- error | ||
- after | ||
padded-blocks: | ||
- error | ||
- never | ||
quote-props: | ||
- error | ||
- as-needed | ||
quotes: | ||
- error | ||
- single | ||
- avoidEscape: true | ||
allowTemplateLiterals: true | ||
semi-spacing: error | ||
semi: error | ||
space-before-blocks: error | ||
space-before-function-paren: | ||
- error | ||
- never | ||
space-in-parens: error | ||
space-infix-ops: error | ||
space-unary-ops: error | ||
spaced-comment: error | ||
template-tag-spacing: error | ||
unicode-bom: error | ||
arrow-body-style: error | ||
arrow-parens: | ||
- error | ||
- as-needed | ||
arrow-spacing: error | ||
no-duplicate-imports: error | ||
no-useless-computed-key: error | ||
no-useless-constructor: error | ||
prefer-arrow-callback: error | ||
prefer-numeric-literals: error | ||
prefer-rest-params: error | ||
prefer-spread: error | ||
prefer-template: error | ||
rest-spread-spacing: error | ||
template-curly-spacing: error | ||
yield-star-spacing: error | ||
no-var: error |
7b2efa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fent What is the purpose of this change? json is a de facto standart and it has a lot of benefits such as VSCode ESLint extension intellisense, readability... I just want to know your opinion on this because in my fork I have converter it back to json format (unfortunately). but ofc Ican revert this chagne
7b2efa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my purpose is to have this config be more readable and more easily configurable by humans. yaml is supported by eslint.
what does vscode intellisense provide if this is in json?
7b2efa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fent Sorry for a bit of inactivity here.
Autocomplete everywhere (except plugins stuff). This is really handy for me, I love autocomplete.
However dbaeumer explained it much better than I did:
So if you have YAML extension installed, everything should work fine :)