fix: fix error about secondaryResult not being iterable

fixes #654
fent · Aug 10, 2020 · 6b051d8 · 6b051d8
1 parent 335bb15
commit 6b051d8
Show file tree

Hide file tree

Showing 9 changed files with 19,535 additions and 19 deletions.
diff --git a/lib/info-extras.js b/lib/info-extras.js
@@ -128,7 +128,7 @@ exports.getAuthor = info => {
  * @returns {Array.<Object>}
  */
 exports.getRelatedVideos = info => {
-  let rvsParams = [], secondaryResults;
+  let rvsParams = [], secondaryResults = [];
   try {
     rvsParams = info.response.webWatchNextResponseExtensionData.relatedVideoArgs.split(',').map(e => qs.parse(e));
   } catch (err) {
@@ -140,7 +140,7 @@ exports.getRelatedVideos = info => {
     return [];
   }
   let videos = [];
-  for (let result of secondaryResults) {
+  for (let result of secondaryResults || []) {
     let details = result.compactVideoRenderer;
     if (details) {
       try {

diff --git a/test/files/refresh.js b/test/files/refresh.js
@@ -134,7 +134,7 @@ const videos = [
     skip: ['watch', 'get_video_info'],
   },
   {
-    id: '3IqtmUscE_U',
+    id: 'B3eAMGXFw1o',
     type: 'related',
     skip: ['get_video_info', /player/],
     saveInfo: true,
@@ -150,7 +150,7 @@ const videos = [
         fn: body => body.replace(/"secondaryResults"/, '""'),
       },
       {
-        page: 'expected-info.json',
+        page: 'watch.json',
         saveAs: 'bad-details',
         fn: body => body.replace(/\\"shortBylineText\\"/g, '\\"___\\"'),
       },
@@ -230,7 +230,7 @@ const refreshVideo = async(video, noRequests) => {
       existingFiles[filename] = false;
     }
     if (video.keep) {
-      for (let filename of video.keep) {
+      for (let filename of video.keep || []) {
         existingFiles[filename] = true;
       }
     }

diff --git a/test/files/videos/related/embed.html b/test/files/videos/related/embed.html
diff --git a/test/files/videos/related/expected-info-bad-details.json b/test/files/videos/related/expected-info-bad-details.json
diff --git a/test/files/videos/related/expected-info-no-results.json b/test/files/videos/related/expected-info-no-results.json
diff --git a/test/files/videos/related/expected-info-no-rvs.json b/test/files/videos/related/expected-info-no-rvs.json
diff --git a/test/files/videos/related/expected-info.json b/test/files/videos/related/expected-info.json
diff --git a/test/files/videos/related/watch-bad-details.json b/test/files/videos/related/watch-bad-details.json
diff --git a/test/files/videos/related/watch.json b/test/files/videos/related/watch.json