test(coverage): add more coverage for info.js and format-utils.js

fent · Oct 25, 2020 · 3f57ce9 · 3f57ce9
1 parent d2d7f94
commit 3f57ce9
Show file tree

Hide file tree

Showing 11 changed files with 8,540 additions and 7 deletions.
diff --git a/lib/format-utils.js b/lib/format-utils.js
@@ -50,7 +50,7 @@ const sortFormatsBy = (a, b, sortBy) => {
 
 
 const sortFormatsByVideo = (a, b) => sortFormatsBy(a, b, [
-  format => parseInt(format.qualityLabel) || 0,
+  format => parseInt(format.qualityLabel),
   getVideoBitrate,
   getVideoEncodingRank,
 ]);
@@ -213,8 +213,6 @@ exports.filterFormats = (formats, filter) => {
  */
 exports.addFormatMeta = format => {
   format = Object.assign({}, FORMATS[format.itag], format);
-  format.qualityLabel =
-    format.qualityLabel || (format.height ? `${format.height}p${format.fps >= 60 ? format.fps : ''}` : null);
   format.hasVideo = !!format.qualityLabel;
   format.hasAudio = !!format.audioBitrate;
   format.container = format.mimeType ?

diff --git a/lib/info.js b/lib/info.js
@@ -109,10 +109,11 @@ exports.getBasicInfo = async(id, options) => {
       !config.embedded_player_response && playErr) {
       throw playErr;
     }
-    let html5playerRes = /<script\s+src="([^"]+)"\s+name="player_ias\/base"\s*>/.exec(body);
-    info.html5player = html5playerRes ? html5playerRes[1] : null;
     info.player = config;
+    let html5playerRes = /<script\s+src="([^"]+)"\s+name="player_ias\/base"\s*>/.exec(body);
+    info.html5player = html5playerRes && html5playerRes[1];
   }
+  info.html5player = info.html5player || (info.player && info.player.assets && info.player.assets.js);
   return gotConfig(id, options, info, body);
 };
 
@@ -193,7 +194,6 @@ const gotConfig = async(id, options, info, body) => {
     info.player_response.microformat.playerMicroformatRenderer,
     info.player_response.videoDetails, additional);
   info.related_videos = extras.getRelatedVideos(info);
-  info.html5player = info.html5player || (info.player && info.player.assets && info.player.assets.js);
 
   return info;
 };

diff --git a/test/files/refresh.js b/test/files/refresh.js
@@ -42,6 +42,10 @@ const videos = [
       },
     ],
   },
+  {
+    id: '21X5lGlDOfg',
+    type: 'live-with-cc',
+  },
   {
     id: 'GgPfoDM4HN0',
     type: 'future-live',

diff --git a/test/files/videos/live-with-cc/dash-manifest.xml b/test/files/videos/live-with-cc/dash-manifest.xml
diff --git a/test/files/videos/live-with-cc/embed.html b/test/files/videos/live-with-cc/embed.html
diff --git a/test/files/videos/live-with-cc/get_video_info b/test/files/videos/live-with-cc/get_video_info
diff --git a/test/files/videos/live-with-cc/hls-manifest.m3u8 b/test/files/videos/live-with-cc/hls-manifest.m3u8
@@ -0,0 +1,13 @@
+#EXTM3U
+#EXT-X-INDEPENDENT-SEGMENTS
+#EXT-X-MEDIA:URI="https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/133/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/captions/1/lang/en/caps_ts_bits/33/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,captions,lang,caps_ts_bits,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRQIhAKRzeO0bZX-rrH1gbCkbz0imxTqpGdJgf9cLRh92NMoGAiA5Svn9oU2rrZr8lAShscs6MtlUC3BgN_cw1QARc2UOSw%3D%3D/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRQIgTstSMutfA2KpJDYuyfdsCkrdoSiyrL41bE00_nx32p0CIQCCv8dykrggvf9eCBgjt5j7TA0BhYd2BpN5Xy5SXtdIWQ%3D%3D/playlist/index.m3u8",TYPE=SUBTITLES,GROUP-ID="vtt",LANGUAGE="en",NAME="en",DEFAULT=NO,AUTOSELECT=YES
+#EXT-X-STREAM-INF:BANDWIDTH=197400,CODECS="mp4a.40.5,avc1.42c00b",RESOLUTION=256x144,FRAME-RATE=30,SUBTITLES="vtt",CLOSED-CAPTIONS=NONE
+https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/91/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/goi/160/sgoap/gir%3Dyes%3Bitag%3D139/sgovp/gir%3Dyes%3Bitag%3D160/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,goi,sgoap,sgovp,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRQIhAJ2kNwR2mJ-zu_Cx87nWlk5Eef4tvQU60m2NZFpX12r4AiB4gnKbaxNOa4Ghm__uaRC0SfTrKH1_7nhkpV_AU-t-Cw%3D%3D/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRQIgXywjb2geGnDVv9qEhqC6meP-7mMzKPIJI_DMVgBta_gCIQDJ5a5lZDZuMdMRnVMx7uRkE-xeqssIpgyivUc1vgvsRg%3D%3D/playlist/index.m3u8
+#EXT-X-STREAM-INF:BANDWIDTH=338100,CODECS="mp4a.40.5,avc1.4d4015",RESOLUTION=426x240,FRAME-RATE=30,SUBTITLES="vtt",CLOSED-CAPTIONS=NONE
+https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/92/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/goi/160/sgoap/gir%3Dyes%3Bitag%3D139/sgovp/gir%3Dyes%3Bitag%3D133/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,goi,sgoap,sgovp,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRAIgXkYXq9pTipBTc6wgeLMQMAW9eOldjyNtXdNEbikebK4CIDyLg8cso4b4xxiGFN-iqmv_6r8zTGZQdisz5SWJwm_Y/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRgIhAOOtqkPoSGmlVmlTKJs0lPoTjDuVt5HhR41cT0SD79UMAiEA4FT7rFGUcVlorQhX2MB6VFljQHVIwqoC7Rwp4k2FaP0%3D/playlist/index.m3u8
+#EXT-X-STREAM-INF:BANDWIDTH=829500,CODECS="mp4a.40.2,avc1.4d401e",RESOLUTION=640x360,FRAME-RATE=30,SUBTITLES="vtt",CLOSED-CAPTIONS=NONE
+https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/93/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/goi/160/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D134/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,goi,sgoap,sgovp,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRAIgUIolVa7sj4qjcHCw9kwLFE7V-9E7S0M26lvBeHV8YBYCICyzD-o_rePIJoDM1e0-3IFJT3XFPUp4pTIPcR8QM_hG/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRAIgVxQyVEk5kUjIiKYXI_rJVy1nzVSvjAj-wbgeUp_W8aQCIEDkTQ_qerKf6_uhgu2LNLInLspqZAKs5Tmtlp7iWtF3/playlist/index.m3u8
+#EXT-X-STREAM-INF:BANDWIDTH=1380750,CODECS="mp4a.40.2,avc1.4d401f",RESOLUTION=854x480,FRAME-RATE=30,SUBTITLES="vtt",CLOSED-CAPTIONS=NONE
+https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/94/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/goi/160/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D135/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,goi,sgoap,sgovp,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRgIhAKvhRW-aixUj9XUASTfCA33e_SMXL-bWJWHEX3V9a_SjAiEA8DiDrGvb1YmcEvglaOWsqf-9fcN-RbiGkmGNDOIBGwE%3D/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRgIhALtYnZ5-G1DsEs4X-SiiRYIG306g9lsEfyjNvVjFqthUAiEA6zFqwgBg0h0l60hvJh9RLkuCsGfbhaVtGMYsBapwvrc%3D/playlist/index.m3u8
+#EXT-X-STREAM-INF:BANDWIDTH=3806250,CODECS="mp4a.40.2,avc1.4d4020",RESOLUTION=1280x720,FRAME-RATE=60,SUBTITLES="vtt",CLOSED-CAPTIONS=NONE
+https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1603618598/ei/xvKUX5z5GYazhwbxzZWYBQ/ip/0.0.0.0/id/21X5lGlDOfg.3/itag/300/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/goi/160/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D298/hls_chunk_host/r5---sn-hp57knsl.googlevideo.com/playlist_duration/30/manifest_duration/30/vprv/1/playlist_type/DVR/initcwndbps/4660/mh/N8/mm/44/mn/sn-hp57knsl/ms/lva/mv/m/mvi/5/pl/24/dover/11/keepalive/yes/mt/1603596856/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,goi,sgoap,sgovp,playlist_duration,manifest_duration,vprv,playlist_type/sig/AOq0QJ8wRAIgKyb252S-th3ohyZOHWWwXLYq81rYD5sizQ7maBAaZtICIAR02eYY5oBXQXx9YxHZLyI4PA9k0PZjvyB5upKZlfzj/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRQIhAKTMxNWrZqHWLAK1k6xIUb3QB_MOi44kk2TmhK3ymEVEAiAZZX3z5mHYT-ExBE33OHYtgpIIU1oz2d9i_QxuVn7IuA%3D%3D/playlist/index.m3u8