fix: fix getting correct videoDetails.lengthSeconds when video is t…

…oo long closes #856
fent · Jan 12, 2021 · 15e7fac · 15e7fac
1 parent 6a9ca4f
commit 15e7fac
Show file tree

Hide file tree

Showing 5 changed files with 92 additions and 2 deletions.
diff --git a/lib/info-extras.js b/lib/info-extras.js
@@ -268,9 +268,10 @@ exports.getDislikes = info => {
  * Cleans up a few fields on `videoDetails`.
  *
  * @param {Object} videoDetails
+ * @param {Object} info
  * @returns {Object}
  */
-exports.cleanVideoDetails = videoDetails => {
+exports.cleanVideoDetails = (videoDetails, info) => {
   videoDetails.thumbnails = videoDetails.thumbnail.thumbnails;
   delete videoDetails.thumbnail;
   utils.deprecate(videoDetails, 'thumbnail', { thumbnails: videoDetails.thumbnails },
@@ -279,6 +280,11 @@ exports.cleanVideoDetails = videoDetails => {
   delete videoDetails.shortDescription;
   utils.deprecate(videoDetails, 'shortDescription', videoDetails.description,
     'videoDetails.shortDescription', 'videoDetails.description');
+
+  // Use more reliable `lengthSeconds` from `playerMicroformatRenderer`.
+  videoDetails.lengthSeconds =
+    info.player_response.microformat &&
+    info.player_response.microformat.playerMicroformatRenderer.lengthSeconds;
   return videoDetails;
 };
 

diff --git a/lib/info.js b/lib/info.js
@@ -87,7 +87,7 @@ exports.getBasicInfo = async(id, options) => {
   info.videoDetails = extras.cleanVideoDetails(Object.assign({},
     info.player_response && info.player_response.microformat &&
     info.player_response.microformat.playerMicroformatRenderer,
-    info.player_response && info.player_response.videoDetails, additional));
+    info.player_response && info.player_response.videoDetails, additional), info);
 
   return info;
 };

diff --git a/test/basic-info-test.js b/test/basic-info-test.js
@@ -195,6 +195,18 @@ describe('ytdl.getBasicInfo()', () => {
     });
   });
 
+  describe('From the longest video uploaded', () => {
+    it('Gets correct `lengthSeconds`', async() => {
+      const id = 'TceijYjxdrQ';
+      const scope = nock(id, 'longest-upload');
+      let info = await ytdl.getBasicInfo(id);
+      scope.done();
+      assert.ok(info);
+      assert.ok(info.videoDetails);
+      assert.equal(info.videoDetails.lengthSeconds, '805000');
+    });
+  });
+
   describe('With cookie headers', () => {
     const id = '_HSylqgVYQI';
     describe('`x-youtube-identity-token` given', () => {

diff --git a/test/files/refresh.js b/test/files/refresh.js
@@ -107,6 +107,11 @@ const videos = [
     basicInfo: true,
     saveInfo: true,
   },
+  {
+    id: 'TceijYjxdrQ',
+    type: 'longest-upload',
+    basicInfo: true,
+  },
 ];
 
 

diff --git a/test/files/videos/longest-upload/watch.html b/test/files/videos/longest-upload/watch.html